WordPress.org

Make WordPress Themes

#5911 closed theme (closed-newer-version-uploaded)

THEME: rtPanel - 2.0.7

Reported by: rtcamp Owned by: greenshady
Priority: Keywords: theme-rtpanel
Cc: admin@…

Description

rtPanel - 2.0.7

WordPress? theme framework with Custom Menu, Header and Background along with Logo, Favicon, Featured Image, Feedburner, Facebook Open Graph, Google Custom Search Integration and more options. This theme comes with free technical support by team of 20+ full-time developers.

Theme URL - http://rtpanel.com
Author URL - http://rtcamp.com

SVN - http://themes.svn.wordpress.org/rtpanel/2.0.7
ZIP - http://wordpress.org/extend/themes/download/rtpanel.2.0.7.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/rtpanel/2.0.6&new_path=/rtpanel/2.0.7

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-rtpanel&order=id

http://themes.svn.wordpress.org/rtpanel/2.0.7/screenshot.png

Change History (6)

comment:1 greenshady19 months ago

  • Owner set to greenshady
  • Status changed from new to assigned

comment:2 greenshady19 months ago

This theme is pretty much good to go. There's just a few issues that definitely need to be fixed. I'm leaving this open for a couple of days for the theme developer to respond and upload a new version.

The things that must be fixed before approval are marked "required" below. As soon as the required issues below are fixed, we can approve this theme.

Internationalization

Here's some strings I noticed that were not wrapped in a translation function.

  • "Show Logo" in rtp-settings-metaboxes.php.
  • "'Read More →'" in loop-common.php.

Required: Theme settings and widgets

Make sure to escape the value attribute for text inputs in your forms. This is your top priority to fix though.

For example:

<input type="text" value="<?php echo $something; ?>" />

That should be:

<input type="text" value="<?php echo esc_attr( $something ); ?>" />

Use esc_url() if it's a URL instead of esc_attr().

Required: Scripts and Styles

Additional stylesheets should be loaded using wp_enqueue_styles() instead of hardcoded in header.php. Make sure to get this fixed.
http://codex.wordpress.org/Function_Reference/wp_enqueue_style

It's great that you loaded scripts using wp_enqueue_script(), but this really belongs in functions.php and hooked to the wp_enqueue_scripts hook.

Backwards Compatibility

There's no need for backwards compatibility checks such as function_exists('dynamic_sidebar') since the rest of your theme isn't backwards compatible.

Required: Unit tests

Post with no title have no link to the permlink page from the archive/home page.

Required: CSS

Galleries with anything more than three images don't display correctly. I believe a user can select up to 9 (or 10) by default, so make sure to get this straightened out.

Review

If you have any questions about the review, please check the Theme Review guidelines or ask in the form below. I'll be happy to help out.
http://codex.wordpress.org/Theme_Review

comment:3 rtcamp19 months ago

Hi greenshady,

Thanks for prompt reply.

I am not able to understand "Required: Unit tests" issue. Please elaborate, and if possible, also provide test-case for the same.

Thanks.
-rtCamp

comment:4 greenshady19 months ago

Download a copy of the theme unit test data. There's a post with no title in it. View this post on an archive-type page.
http://codex.wordpress.org/Theme_Unit_Test

For the particular note about this:
http://codex.wordpress.org/Theme_Unit_Test#.28no_title.29

If a post without a title is displayed on an archive-type view, users must have a way to get to the single post. Therefore, you must display a link when there's no post title.

comment:5 rtcamp19 months ago

Hi greenshady,

I have fixed the above mentioned issues.

Regarding "Required: Unit Tests" ( comment:2 and comment:4 ), we have the "Continue Reading..." link below each excerpted post. Hence the users can get to the single post through the "Continue Reading..." link.

Link to new ticket -> http://themes.trac.wordpress.org/ticket/5996

Thanks.
-rtCamp

comment:6 chipbennett18 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.